feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor#2948
feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor#2948KKiiim wants to merge 11 commits intoAssemblyScript:mainfrom
makeFieldInitializationInConstructor#2948Conversation
KKiiim
changed the title
makeFieldInitializationInConstructormakeFieldInitializationInConstructor
HerrCai0907
left a comment
HerrCai0907
left a comment
There was a problem hiding this comment.
optimization goal LGTM. But I think we should only check whether the field is straightly initialized by zero and ignore it.
|
@CountBleck Could you please have a look on this PR (^_^) |
CountBleck
left a comment
CountBleck
left a comment
There was a problem hiding this comment.
This seems mostly okay, but I'm wondering what all the removed $~lib/arraybuffer/ArrayBufferView#set:buffer is about...what is that setter function supposed to be doing anyway?
I'd like @MaxGraey to sign off before merging.
|
@coderabbitai summary |
|
Ping @MaxGraey @CountBleck Thanks for review again |
|
Ping for review @MaxGraey @CountBleck @HerrCai0907 |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions! |
|
This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards. |
4 participants
Reduce unnecessary zero-initialization memory in the constructor
According to wasm-spec, grown memories should initialized with value 0x00
I've read the contributing guidelines
I've added my name and email to the NOTICE file